Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5.x Evaluation for auto NSG creation with defaults #801

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

devoncrouse
Copy link
Contributor

The fallback to "auto" was not working properly as a value of null was found:

lookup(local.bastion_nsg_config, "create", "auto") == "always",

This is now coalesced to the default value "auto" as expected.

Signed-off-by: Devon Crouse <devon.crouse@oracle.com>
@devoncrouse devoncrouse requested a review from hyder August 15, 2023 10:39
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 15, 2023
Copy link
Contributor

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@hyder hyder merged commit 7c5c563 into oracle-terraform-modules:5.x Aug 15, 2023
1 check passed
@devoncrouse devoncrouse deleted the fix-nsgs branch August 15, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants