fix: Remove sensitive mask from RDMA CNI #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oguz Pastirmaci <oguz.pastirmaci@oracle.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
hyder
approved these changes
Nov 22, 2023
|
@OguzPastirmaci we are including your contribution into main by copying it directly and we'll close the PR here. |
robo-cap
added a commit
to robo-cap/terraform-oci-oke
that referenced
this pull request
Mar 28, 2024
robo-cap
added a commit
to robo-cap/terraform-oci-oke
that referenced
this pull request
Mar 28, 2024
hyder
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #872 with the OCA accepted.
This value is an HTTP response to a publicly accessible daemonset
manifest but it's being marked as sensitive.
It's marked as sensitive, but then it's used in the body of an error
message for a precondition:
https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/main/modules/extensions/rdma_cni_plugin.tf#L61
Because of this variable being in the error message, terraform plan
will exit with exit code 1 even though the plan itself actually
succeeded.
This variable shouldn't be marked sensitive anyways, as its holding the
value for an already public yaml file.