fix: Remove sensitive mask from RDMA CNI #873
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #872 with the OCA accepted.
This value is an HTTP response to a publicly accessible daemonset
manifest but it's being marked as sensitive.
It's marked as sensitive, but then it's used in the body of an error
message for a precondition:
https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/main/modules/extensions/rdma_cni_plugin.tf#L61
Because of this variable being in the error message, terraform plan
will exit with exit code 1 even though the plan itself actually
succeeded.
This variable shouldn't be marked sensitive anyways, as its holding the
value for an already public yaml file.