-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in NSG rule for health check? (incorrect direction, or incorrect description?) #891
Conversation
modules/network/nsg-workers.tf
Outdated
@@ -33,7 +33,7 @@ locals { | |||
"Allow TCP egress from workers to OKE control plane" : { | |||
protocol = local.tcp_protocol, port = local.oke_port, destination = local.control_plane_nsg_id, destination_type = local.rule_type_nsg, | |||
}, | |||
"Allow TCP ingress to workers for health check from OKE control plane" : { | |||
"Allow TCP egress to workers for health check from OKE control plane" : { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Allow TCP egress to OKE control plane from workers for health check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review the recommended changes
@hyder -The change has already been done and can be merged. |
your description is still incorrect. |
@hyder - " Allow TCP egress to OKE control plane from workers for health check" Is this the correct description ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Resolves #820