Bug in NSG rule for health check? (incorrect direction, or incorrect description?) #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
hyder
changed the title
hyder
reviewed
Feb 6, 2024
modules/network/nsg-workers.tf
Outdated
| @@ -33,7 +33,7 @@ locals { | |||
| "Allow TCP egress from workers to OKE control plane" : { | |||
| protocol = local.tcp_protocol, port = local.oke_port, destination = local.control_plane_nsg_id, destination_type = local.rule_type_nsg, | |||
| }, | |||
| "Allow TCP ingress to workers for health check from OKE control plane" : { | |||
| "Allow TCP egress to workers for health check from OKE control plane" : { | |||
There was a problem hiding this comment.
This should be Allow TCP egress to OKE control plane from workers for health check
hyder
requested changes
Feb 6, 2024
|
@hyder -The change has already been done and can be merged. |
your description is still incorrect. |
|
@hyder - " Allow TCP egress to OKE control plane from workers for health check" Is this the correct description ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #820