Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodepool support for max_pods_per_node #904

Merged
merged 1 commit into from
Mar 12, 2024
Merged

add nodepool support for max_pods_per_node #904

merged 1 commit into from
Mar 12, 2024

Conversation

robo-cap
Copy link
Member

fixes #902 .

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 11, 2024
hyder
hyder requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Question about whether this should be added for flannel too
  2. Global default should be used when the node pool does not specify the value

hyder
hyder requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check again

@hyder hyder self-requested a review March 12, 2024 23:21
hyder
hyder approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@hyder hyder merged commit c0d8158 into oracle-terraform-modules:main Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyder hyder hyder approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for node pool specific max_pods_per_node
2 participants
@robo-cap @hyder