-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to ignore_size attribute on nodepools #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyder
reviewed
Jun 28, 2024
hyder
reviewed
Jun 28, 2024
hyder
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments below
0fbf869
to
baff8a3
Compare
74166a4
to
490a712
Compare
devoncrouse
reviewed
Jul 2, 2024
devoncrouse
reviewed
Jul 2, 2024
devoncrouse
reviewed
Jul 2, 2024
hyder
reviewed
Jul 2, 2024
hyder
reviewed
Jul 2, 2024
hyder
reviewed
Jul 3, 2024
hyder
previously requested changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments inline
devoncrouse
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to associate nodepools with
oci_containerengine_node_pool
terraform resources that ignore nodepool size. This is useful for nodepools managed by the cluster autoscaler.Add
ignore_initial_pool_size = true
to the nodepool attributes.Adding this attribute to an existing nodepool will trigger the recreation of it.
If you intend to set the attribute ignore_initial_pool_size = true for some of the nodepools, you need to use the terraform state mv command.
Documentation was updated, should be available here: https://oracle-terraform-modules.github.io/terraform-oci-oke/guide/extensions_cluster_autoscaler.html
Resolves #763