Add support to ignore_size attribute on nodepools #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
hyder
reviewed
Jun 28, 2024
hyder
reviewed
Jun 28, 2024
robo-cap
force-pushed
the
main
branch
2 times, most recently
from
0fbf869
to
baff8a3
Compare
robo-cap
force-pushed
the
main
branch
2 times, most recently
from
74166a4
to
490a712
Compare
devoncrouse
reviewed
Jul 2, 2024
devoncrouse
reviewed
Jul 2, 2024
devoncrouse
reviewed
Jul 2, 2024
hyder
reviewed
Jul 2, 2024
hyder
reviewed
Jul 2, 2024
hyder
reviewed
Jul 3, 2024
devoncrouse
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to associate nodepools with
oci_containerengine_node_poolterraform resources that ignore nodepool size. This is useful for nodepools managed by the cluster autoscaler.Add
ignore_initial_pool_size = trueto the nodepool attributes.Adding this attribute to an existing nodepool will trigger the recreation of it.
If you intend to set the attribute ignore_initial_pool_size = true for some of the nodepools, you need to use the terraform state mv command.
Documentation was updated, should be available here: https://oracle-terraform-modules.github.io/terraform-oci-oke/guide/extensions_cluster_autoscaler.html
Resolves #763