-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unittests for aqua.evaluation/finetuning and handlers(evaluation/common/base) #763
Conversation
ads/aqua/evaluation.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mingkang111 , could you please reset this file to what is in main? I understand that it is only comments and formatting. But Would like only change to tests folder to the master before we make changes to any code of any kind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
c212b0a
As per @VipulMascarenhas request, merging PR #773 for handler test into this PR. |
a3490dd
The failing operation test picking up |
PR contains unittest for aqua.evaluation, aqua.finetuning, evaluation handler, common handler, and base handler.
Coverage
This PR also includes @lu-ohai 's contribution on
create
evaluation and FT.