Fix nodepool reconciliation issue (#327)

* Fix reconciliation comparisons when there are no NSGs
oracle · Sep 11, 2023 · 3cff30b · 3cff30b
1 parent 4be9fc9
commit 3cff30b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cloud/scope/util.go b/cloud/scope/util.go
@@ -26,6 +26,9 @@ const (
 
 // GetNsgNamesFromId returns the names of the NSGs with the provided IDs
 func GetNsgNamesFromId(ids []string, nsgs []*infrastructurev1beta2.NSG) []string {
+	if len(ids) == 0 {
+		return nil
+	}
 	names := make([]string, 0)
 	for _, id := range ids {
 		for _, nsg := range nsgs {

diff --git a/exp/controllers/ocimanaged_machinepool_controller.go b/exp/controllers/ocimanaged_machinepool_controller.go
@@ -357,7 +357,6 @@ func (r *OCIManagedMachinePoolReconciler) reconcileManagedMachines(ctx context.C
 	specInfraMachines := make([]infrav2exp.OCIMachinePoolMachine, 0)
 	for _, node := range nodePool.Nodes {
 		// deleted/failing nodes should not be added to spec
-		machinePoolScope.Info(string(node.LifecycleState))
 		if node.LifecycleState == oke.NodeLifecycleStateDeleted || node.LifecycleState == oke.NodeLifecycleStateFailing {
 			continue
 		}