Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory field from OCIClusterSpec and use webhook validation instead #66

Closed
joekr opened this issue Apr 21, 2022 · 0 comments · Fixed by #67
Closed

Remove mandatory field from OCIClusterSpec and use webhook validation instead #66

joekr opened this issue Apr 21, 2022 · 0 comments · Fixed by #67
Assignees
Labels
enhancement New feature or request

Comments

@joekr
Copy link
Member

joekr commented Apr 21, 2022

What would you like to be added:
We want to remove the mandatory from CompartmentId string `mandatory:"true" json:"compartmentId"` in the OCIClusterSpec and setup the mandatory validation in ocicluster_webhook

Why is this needed:
This seems to be the preferred way to do validation and it will allow use to remove the compartmentId: REPLACE defined in templates/clusterclass-example.yaml

@joekr joekr added the enhancement New feature or request label Apr 21, 2022
@joekr joekr self-assigned this Apr 22, 2022
@joekr joekr closed this as completed in #67 Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant