Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove CompartmentId mandatory from ocicluster_types #67

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented Apr 22, 2022

What this PR does / why we need it:
CompartmentId is still mandatory, but the admission webhook is now handling the validation.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66

CompartmentId is still mandatory, but the admission webhook
is now handling the validation.
@joekr
Copy link
Member Author

joekr commented Apr 22, 2022

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  0.247s  coverage: 7.8% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.741s  coverage: 30.3% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  175.824s        coverage: 81.9% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  26.485s coverage: 70.7% of statements

e2e tests

Summarizing 1 Failure:

[Fail] Workload cluster creation [It] Cloud Provider OCI testing [PRBlocking]
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/ccm_helpers.go:83

Ran 5 of 21 Specs in 1942.343 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 16 Skipped

running CCM in SYD

• [SLOW TEST:1064.703 seconds]
Workload cluster creation
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:49
  Cloud Provider OCI testing [PRBlocking]
  /home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:201
------------------------------
STEP: Tearing down the management cluster


Ran 1 of 21 Specs in 1149.704 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 20 Skipped

@joekr joekr marked this pull request as ready for review April 22, 2022 18:16
@joekr joekr self-assigned this Apr 22, 2022
@joekr joekr merged commit 4ae7195 into oracle:main Apr 23, 2022
@joekr joekr deleted the issue-66-remove-mandatory-field branch April 26, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mandatory field from OCIClusterSpec and use webhook validation instead
2 participants