Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation for OCICluster #70

Closed
joekr opened this issue Apr 25, 2022 · 0 comments · Fixed by #77
Closed

Add more validation for OCICluster #70

joekr opened this issue Apr 25, 2022 · 0 comments · Fixed by #77
Assignees
Labels
enhancement New feature or request

Comments

@joekr
Copy link
Member

joekr commented Apr 25, 2022

What would you like to be added:
Now that #55 has been merged we need to work on adding more validation checks for things like the following:

  • NetworkSpec (valid CIDRs)
  • Region is valid (might need to call to OCI for validation or the OCI SDK might have pre-flight validation we could use)
  • ClusterName (length?)
  • For cluster update region is considered an immutable field. We will want to handle other immutable fields

Why is this needed:
Now that #55 is merged we should expand upon our validation. This issue isn't to 100% cover all possibilities, but rather cover what we can now that make sense.

@joekr joekr added the enhancement New feature or request label Apr 25, 2022
@joekr joekr self-assigned this Apr 27, 2022
@joekr joekr closed this as completed in #77 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant