Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations using validation webhooks #55

Closed
shyamradhakrishnan opened this issue Apr 7, 2022 · 1 comment · Fixed by #62
Closed

Add validations using validation webhooks #55

shyamradhakrishnan opened this issue Apr 7, 2022 · 1 comment · Fixed by #62
Assignees
Labels
enhancement New feature or request

Comments

@shyamradhakrishnan
Copy link
Contributor

What would you like to be added:
Add validations via validation webhook.

Why is this needed:
Validation webhooks will make sure that mandatory parameters are set much before reconciliation so that users can catch errors much earlier. Currently all validations happen during reconciliation.

@joekr
Copy link
Member

joekr commented Apr 8, 2022

For this issue we will be simply adding a single validation to a cluster and one to a machine. This way we can get something landed quickly, then we will go and back-fill more of the needed validations.

For now we will validate the compartment for the OCICluster and the imageId for the OCIMachineTemplate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants