Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation for OCIMachineTemplate #71

Closed
joekr opened this issue Apr 25, 2022 · 1 comment · Fixed by #75
Closed

Add more validation for OCIMachineTemplate #71

joekr opened this issue Apr 25, 2022 · 1 comment · Fixed by #75
Assignees
Labels
enhancement New feature or request

Comments

@joekr
Copy link
Member

joekr commented Apr 25, 2022

What would you like to be added:
Now that #55 has been merged we need to work on adding more validation checks for things like the following:

Why is this needed:
Now that #55 is merged we should expand upon our validation. This issue isn't to 100% cover all possibilities, but rather cover what we can now that make sense.

@joekr joekr added the enhancement New feature or request label Apr 25, 2022
@joekr joekr self-assigned this Apr 26, 2022
@joekr
Copy link
Member Author

joekr commented Apr 26, 2022

After speaking with the team we've decided to limit how strictly we validate for now. Things like IsPvEncryptionInTransitEnabled are documented and handled on the compute side. Having the client side handle validation will start to become brittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant