Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination to MachinePool list api calls #100

Merged
merged 1 commit into from
May 27, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented May 26, 2022

What this PR does / why we need it:
Since it is possible for a MachinePool to be quite large we need to
make sure we iterate through all pages of possible machine pool
instances.

We have another ticket to make sure all other list calls are also
paginated.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #99

Since it is possible for a MachinePool to be quite large we need to
make sure we iterate through all pages of possible machine pool
instances.

We have another ticket to make sure all other list calls are also
paginated.
@joekr joekr added the enhancement New feature or request label May 26, 2022
@joekr joekr self-assigned this May 26, 2022
@joekr
Copy link
Member Author

joekr commented May 26, 2022

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  0.251s  coverage: 18.7% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.784s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  176.016s        coverage: 73.4% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  26.314s coverage: 71.0% of statements
?       github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      [no test files]
?       github.com/oracle/cluster-api-provider-oci/exp/controllers      [no test files]
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]

e2e tests

Summarizing 1 Failure:

[Fail] Workload cluster creation [It] Cloud Provider OCI testing [PRBlocking]
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/ccm_helpers.go:83

Ran 5 of 21 Specs in 2097.521 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 16 Skipped

currently main is failing the same test for me. Looks like it is due to "public IP" limits.

Used SYD and CCM passed

• [SLOW TEST:1045.678 seconds]
Workload cluster creation
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:49
  Cloud Provider OCI testing [PRBlocking]
  /home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:201
------------------------------
STEP: Tearing down the management cluster


Ran 1 of 21 Specs in 1131.153 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 20 Skipped

@joekr joekr marked this pull request as ready for review May 27, 2022 04:16
@joekr joekr merged commit b5cca41 into oracle:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination for Machine Pools
2 participants