Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Tilt support for local development #102

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

joekr
Copy link
Member

@joekr joekr commented Jun 3, 2022

What this PR does / why we need it:
This will allow for more rapid development as tilt supports
hot reload on code changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No open issues currently

@joekr joekr added the enhancement New feature or request label Jun 3, 2022
@joekr joekr self-assigned this Jun 3, 2022
@joekr
Copy link
Member Author

joekr commented Jun 3, 2022

I need to create a doc somewhere temporarily to explain a bit how to work with Tilt. Once we have an official development guild all this will be moved in as well.

cat <<EOF > tilt-settings.json
{
  "kustomize_substitutions": {
      "OCI_TENANCY_ID_B64": "$(echo "${OCI_TENANCY_ID}" | tr -d '\n' | base64 | tr -d '\n')",
      "OCI_CREDENTIALS_FINGERPRINT_B64": "$(echo "${OCI_CREDENTIALS_FINGERPRINT}" | tr -d '\n' | base64 | tr -d '\n')",
      "OCI_USER_ID_B64": "$(echo "${OCI_USER_ID}" | tr -d '\n' | base64 | tr -d '\n')",
      "OCI_REGION_B64": "$(echo "${OCI_REGION}" | tr -d '\n' | base64 | tr -d '\n')",
      "OCI_CREDENTIALS_KEY_B64": "$(echo "${OCI_CREDENTIALS_KEY_PATH}" | tr -d '\n' | base64 | tr -d '\n')"
  }
}
EOF

UPDATE
I've added a local-dev.md doc as a temporary "HOW TO" doc while we work on the actual book's development page.

@joekr
Copy link
Member Author

joekr commented Jun 3, 2022

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  0.251s  coverage: 18.7% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.208s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  176.020s        coverage: 73.4% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  26.255s coverage: 71.0% of statements
?       github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      [no test files]
?       github.com/oracle/cluster-api-provider-oci/exp/controllers      [no test files]
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]

e2e tests

Ran 5 of 22 Specs in 1975.032 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 17 Skipped


Ginkgo ran 1 suite in 33m47.333217601s
Test Suite Passed

@joekr joekr marked this pull request as ready for review June 3, 2022 02:25
@joekr joekr force-pushed the add-tilt branch 4 times, most recently from d4c285a to c476931 Compare June 8, 2022 19:00
Copy link
Member

@arindam-bandyopadhyay arindam-bandyopadhyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will allow for more rapid development as tilt supports
hot reload on code changes.
@joekr joekr merged commit e340d5d into oracle:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants