Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add version information #126

Merged
merged 1 commit into from
Aug 24, 2022
Merged

feat: Add version information #126

merged 1 commit into from
Aug 24, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented Aug 18, 2022

What this PR does / why we need it:
This allows us to use build version information to help debug
issues.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No open issue

docs/src/SUMMARY.md Outdated Show resolved Hide resolved
@joekr
Copy link
Member Author

joekr commented Aug 18, 2022

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  1.303s  coverage: 18.7% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.711s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  177.792s        coverage: 73.5% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  27.591s coverage: 71.0% of statements
?       github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      [no test files]
?       github.com/oracle/cluster-api-provider-oci/exp/controllers      [no test files]
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]
?       github.com/oracle/cluster-api-provider-oci/version      [no test files]

e2e

Summarizing 3 Failures:

[Fail] Workload cluster creation [It] Cloud Provider OCI testing [PRBlocking]
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/ccm_helpers.go:83

[Fail] Workload cluster creation [It] Default CNI - With 3 control plane nodes spread across failure domains [PRBlocking]
/home/ubuntu/projects/cluster-api-provider-oci/vendor/sigs.k8s.io/cluster-api/test/framework/controlplane_helpers.go:116

[Fail] Workload cluster creation [It] Custom networking NSG [PRBlocking]
/home/ubuntu/projects/cluster-api-provider-oci/vendor/sigs.k8s.io/cluster-api/test/framework/machinedeployment_helpers.go:129

Ran 5 of 22 Specs in 3315.794 seconds
FAIL! -- 2 Passed | 3 Failed | 0 Pending | 17 Skipped

-- Custom networking NSG 

• [SLOW TEST:1023.907 seconds]
Workload cluster creation
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:50
  Default CNI - With 3 control plane nodes spread across failure domains [PRBlocking]
  /home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:134
------------------------------
STEP: Tearing down the management cluster

-- 3 control plane nodes spread across failure domains 

Ran 1 of 22 Specs in 1117.831 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 21 Skipped

• [SLOW TEST:679.482 seconds]
Workload cluster creation
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:50
  Custom networking NSG [PRBlocking]
  /home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:287
------------------------------
STEP: Tearing down the management cluster


Ran 1 of 22 Specs in 766.386 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 21 Skipped

-- CCM Test 

• [SLOW TEST:983.054 seconds]
Workload cluster creation
/home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:50
  Cloud Provider OCI testing [PRBlocking]
  /home/ubuntu/projects/cluster-api-provider-oci/test/e2e/cluster_test.go:202
------------------------------
STEP: Tearing down the management cluster


Ran 1 of 22 Specs in 1061.635 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 21 Skipped

This allows us to use build version information to help debug
issues.
@joekr joekr self-assigned this Aug 19, 2022
@joekr joekr changed the title Add version information feat: Add version information Aug 19, 2022
@joekr joekr added the enhancement New feature or request label Aug 23, 2022
@joekr joekr marked this pull request as ready for review August 23, 2022 13:13
Copy link
Contributor

@shyamradhakrishnan shyamradhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a comment on the version will look like? just an example

@joekr
Copy link
Member Author

joekr commented Aug 24, 2022

Version examples

  • development - if the GitVersion isn't set
  • v0.4.0-dirty - on a working branch if there are changes
  • v0.4.0 - on the release once the release is actually built (this is based on the git tag)

@joekr joekr merged commit f638fc5 into oracle:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants