Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for MaxConcurrentReconciles for reconcilers #152

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented Sep 13, 2022

What this PR does / why we need it:
This sets up default parameters and allows users to modify the number of concurrent reconcilers for the OCIClusterReconciler, OCIMachineReconciler, OCIMachinePoolReconciler, OCIManagedMachinePoolReconciler, OCIManagedClusterReconciler and the OCIManagedClusterControlPlaneReconciler.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #149

This sets up default parameters and allows users to modify the number of
concurrent reconcilers for the `OCIClusterReconciler`,
`OCIMachineReconciler`, `OCIMachinePoolReconciler`,
`OCIManagedMachinePoolReconciler`, `OCIManagedClusterReconciler` and the
`OCIManagedClusterControlPlaneReconciler`.
@joekr joekr added the enhancement New feature or request label Sep 13, 2022
@joekr joekr self-assigned this Sep 13, 2022
@joekr
Copy link
Member Author

joekr commented Sep 13, 2022

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  1.544s  coverage: 25.8% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.854s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  168.608s        coverage: 72.6% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  27.920s coverage: 69.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      1.354s  coverage: 10.1% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/controllers      3.196s  coverage: 43.4% of statements
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]
?       github.com/oracle/cluster-api-provider-oci/version      [no test files]

e2e tests

Ran 5 of 22 Specs in 1751.391 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 17 Skipped

@joekr joekr marked this pull request as ready for review September 13, 2022 17:39
@joekr joekr merged commit 6b9c051 into oracle:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce parameters about reconcile concurrency
2 participants