Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update e2e test version and ccm version #153

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

joekr
Copy link
Member

@joekr joekr commented Sep 15, 2022

What this PR does / why we need it:
make 1.24 default version in test.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #139

@joekr joekr added the enhancement New feature or request label Sep 15, 2022
@joekr joekr self-assigned this Sep 15, 2022
Copy link
Member

@shyamradhakrishnan shyamradhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add the changes other than just the image in the addons template right?

@joekr
Copy link
Member Author

joekr commented Sep 15, 2022

unit test

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  1.389s  coverage: 25.8% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.800s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  168.163s        coverage: 72.6% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  27.638s coverage: 69.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      1.272s  coverage: 10.1% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/controllers      2.891s  coverage: 43.4% of statements
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]
?       github.com/oracle/cluster-api-provider-oci/version      [no test files]

e2e test

Ran 5 of 22 Specs in 1725.488 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 17 Skipped

@joekr joekr marked this pull request as ready for review September 15, 2022 11:53
@joekr joekr marked this pull request as draft September 15, 2022 11:54
make 1.24 default version in test, support 1.24 to 1.25
@joekr
Copy link
Member Author

joekr commented Sep 15, 2022

we need to add the changes other than just the image in the addons template right?

@shyamradhakrishnan I have updated cluster-template-oci-addons.yaml with the same changes that are in the test/e2e/data/ccm/ccm.yaml file.

@joekr joekr marked this pull request as ready for review September 15, 2022 13:32
@joekr joekr merged commit aad7363 into oracle:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update upgrade e2e test
2 participants