test: ignore more e2e templates #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joekr why do we need these files? these are generated at runtime right? https://github.com/oracle/cluster-api-provider-oci/tree/main/test/e2e/data/infrastructure-oci/v1beta1 has no template files. I may be missing something though. |
|
I was thinking the wrong way. I needed to add them to |
joekr
force-pushed
the
add-e2e-templates
branch
from
fa42358
to
a468e6b
Compare
after running `make generate-e2e-templates` I notice two templates weren't ignored like our other ones.
joekr
force-pushed
the
add-e2e-templates
branch
from
a468e6b
to
7bdae54
Compare
joekr
changed the title
shyamradhakrishnan
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
after running
make generate-e2e-templatesI notice two templates weren't ignored like our other ones.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):No open issues for this.