Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for OKE and bug fixes #172

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Add doc for OKE and bug fixes #172

merged 1 commit into from
Feb 11, 2023

Conversation

shyamradhakrishnan
Copy link
Member

What this PR does / why we need it:
Addo docs for OKE support and minor bug fixes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #151 , #145

joekr
joekr requested changes Sep 28, 2022
View reviewed changes
Copy link
Member

@joekr joekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few small requests.

templates/cluster-template-managed-private.yaml Show resolved Hide resolved
docs/src/managed/networking.md Outdated Show resolved Hide resolved
docs/src/managed/networking.md Outdated Show resolved Hide resolved
docs/src/managed/managedcluster.md Outdated Show resolved Hide resolved
docs/src/managed/managedcluster.md Outdated Show resolved Hide resolved
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 10, 2023
@shyamradhakrishnan shyamradhakrishnan marked this pull request as ready for review February 10, 2023 12:34
joekr
joekr previously approved these changes Feb 10, 2023
View reviewed changes
docs/src/managed/managedcluster.md Show resolved Hide resolved
@shyamradhakrishnan
Copy link
Member Author

e2e tests

------------------------------
[SynchronizedAfterSuite] PASSED [0.959 seconds]
[SynchronizedAfterSuite]
/home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/test/e2e/e2e_suite_test.go:252

  Timeline >>
  STEP: Tearing down the management cluster @ 02/11/23 03:13:11.851
  << Timeline
------------------------------

Ran 6 of 24 Specs in 2772.940 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 18 Skipped

@shyamradhakrishnan shyamradhakrishnan merged commit 79ff79f into oracle:main Feb 11, 2023
@shyamradhakrishnan shyamradhakrishnan deleted the add_docs_for_oke branch February 11, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for OKE support
2 participants
@shyamradhakrishnan @joekr