-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update templates to specify control and worker shapes separately #19
Conversation
c8fceba
to
c37649f
Compare
c37649f
to
62174bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also decide how we are going to call the instances: instance, machine, node. Let's pick 1 term and use it consistently. Instance is usually an OCI term whereas I think node is a K8s term and machine is a CAPI term.
1b27ff8
to
5e70569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few cosmetic changes
I actually got this wrong in my suggestions: the OCI Style Guide requires periods at the end of all sentences, including those in table cells. In this case, this is usually only the content in the description field. Please do add periods at the end of each sentence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an output of e2e test and unit test, just for the sake of completeness
5e70569
to
4fd60b9
Compare
Still working on the CCM test, but I think that one is on me. I'm going to rerun after an image update
Update
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that I just noticed: our examples don't cover all the options. It would be good if we can provide an example usage of all available parameters. It doesn't all have to be in a single example but rather all parameters must be used at least once across all the provided examples.
I've created #35 to cover all the examples @Djelibeybi |
905f41c
to
145780e
Compare
While the users can specify the shapes independently we wanted our defined templates to support this as well. It should make it easier for our users to quickly define different shapes independent of each other.
We are removing this from our main templates otherwise we have to set a default which users might not set when changing the OCPU and could cause issues.
145780e
to
4025ace
Compare
I've addressed the changes. Not sure why it is still blocking the PR
What this PR does / why we need it:
While the users can specify the shapes independently we wanted our
defined templates to support this as well. It should make it easier
for our users to quickly define different shapes independent of each
other.
Which issue(s) this PR fixes:
Fixes #15