Move ad map to spec #228
Closed
Move ad map to spec #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
e2e test |
|
unit test |
joekr
approved these changes
Mar 20, 2023
| for i, ad := range respAd.Items { | ||
| s.SetFailureDomain(strconv.Itoa(i+1), clusterv1.FailureDomainSpec{ | ||
| for k := range adMap { | ||
| adIndex := strings.LastIndexAny(k, "-") |
There was a problem hiding this comment.
I see all the tests are changed from ad1 to ad-1 did something change? I know that AD names are something like US-ASHBURN-AD-1 but wasn't sure why this was changed in our code.
There was a problem hiding this comment.
yes, the code was changed few lines before to use the map from spec rather than the response object, for which we have to parse the ad name.
joekr
reviewed
Mar 20, 2023
| SETUP_ENVTEST_VER := v0.0.0-20230131074648-f5014c077fc3 | ||
| SETUP_ENVTEST_BIN := setup-envtest | ||
| SETUP_ENVTEST := $(abspath $(TOOLS_BIN_DIR)/$(SETUP_ENVTEST_BIN)-$(SETUP_ENVTEST_VER)) | ||
| SETUP_ENVTEST_PKG := sigs.k8s.io/controller-runtime/tools/setup-envtest |
There was a problem hiding this comment.
And I want to discuss this new tool so I understand its usecase
There was a problem hiding this comment.
did not change the tool, made the code similar to other providers as the old code was giving problems in arm64 mac. The old code was using older version of controller runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move ad map to spec. This will enable users to specify AD information in the cluster spec.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #227