-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ad map to spec #228
Move ad map to spec #228
Conversation
e2e test
|
unit test
|
for i, ad := range respAd.Items { | ||
s.SetFailureDomain(strconv.Itoa(i+1), clusterv1.FailureDomainSpec{ | ||
for k := range adMap { | ||
adIndex := strings.LastIndexAny(k, "-") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see all the tests are changed from ad1
to ad-1
did something change? I know that AD names are something like US-ASHBURN-AD-1
but wasn't sure why this was changed in our code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the code was changed few lines before to use the map from spec rather than the response object, for which we have to parse the ad name.
SETUP_ENVTEST_VER := v0.0.0-20230131074648-f5014c077fc3 | ||
SETUP_ENVTEST_BIN := setup-envtest | ||
SETUP_ENVTEST := $(abspath $(TOOLS_BIN_DIR)/$(SETUP_ENVTEST_BIN)-$(SETUP_ENVTEST_VER)) | ||
SETUP_ENVTEST_PKG := sigs.k8s.io/controller-runtime/tools/setup-envtest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I want to discuss this new tool so I understand its usecase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not change the tool, made the code similar to other providers as the old code was giving problems in arm64 mac. The old code was using older version of controller runtime.
What this PR does / why we need it:
Move ad map to spec. This will enable users to specify AD information in the cluster spec.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #227