Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment API version to support new reconciliation API and move rel… #232

Merged
merged 21 commits into from
Mar 30, 2023
Merged

Increment API version to support new reconciliation API and move rel… #232

merged 21 commits into from
Mar 30, 2023

Conversation

shyamradhakrishnan
Copy link
Member

@shyamradhakrishnan shyamradhakrishnan commented Mar 23, 2023 •
edited
Loading

…ated fields

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #227, #225

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 23, 2023
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
80dbf78 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
ecc8ba8 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
0ee3bd3 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
85667fd 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
433cd3c 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
fa3a2e2 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
98dece2 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
638efc4 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
73bf366 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
2886984 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
aa67802 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
5a36adf 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
4377be5 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
21ae816 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
d88af2b 
…ated fields
@shyamradhakrishnan
Increment API version to support new reconciliation APPI and move rel…
32d2522 
…ated fields
@shyamradhakrishnan shyamradhakrishnan marked this pull request as ready for review March 27, 2023 09:00
@shyamradhakrishnan
Copy link
Member Author

unit test

?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	38.600s	coverage: 22.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta2	0.057s	coverage: 16.3% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.010s	coverage: 25.0% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	165.959s	coverage: 76.6% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/util	0.028s	coverage: 60.0% of statements
ok  	github.com/oracle/cluster-api-provider-oci/controllers	25.885s	coverage: 67.6% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1	32.000s	coverage: 21.7% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2	0.026s	coverage: 11.0% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/controllers	0.764s	coverage: 56.3% of statements
?   	github.com/oracle/cluster-api-provider-oci/feature	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/version	[no test files]
go tool cover -func=coverage.out -o coverage.txt
go tool cover -html=coverage.out -o coverage.html

joekr
joekr previously approved these changes Mar 27, 2023
View reviewed changes
exp/api/v1beta1/ocimanagedcluster_conversion.go Outdated Show resolved Hide resolved
@shyamradhakrishnan
Copy link
Member Author

e2e test


Ran 6 of 26 Specs in 2724.962 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 20 Skipped

@shyamradhakrishnan shyamradhakrishnan changed the title Increment API version to support new reconciliation APPI and move rel… Increment API version to support new reconciliation API and move rel… Mar 28, 2023
joekr
joekr reviewed Mar 28, 2023
View reviewed changes
api/v1beta1/conversion.go Show resolved Hide resolved
api/v1beta1/conversion.go Show resolved Hide resolved
api/v1beta1/groupversion_info.go Show resolved Hide resolved
api/v1beta1/ociclusteridentity_conversion.go Show resolved Hide resolved
cloud/scope/cluster.go Show resolved Hide resolved
api/v1beta2/ocicluster_webhook.go Show resolved Hide resolved
cloud/scope/internet_gateway_reconciler.go Show resolved Hide resolved
api/v1beta2/conversion.go Show resolved Hide resolved
@joekr joekr added the enhancement New feature or request label Mar 29, 2023
@shyamradhakrishnan shyamradhakrishnan merged commit f620d39 into oracle:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

Assignees

@shyamradhakrishnan shyamradhakrishnan

Labels
enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move AvailabilityDomains from OCI Cluster status to spec
2 participants
@shyamradhakrishnan @joekr