Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self managed nodes move oke from exp #298

Merged
merged 14 commits into from
Jul 7, 2023
Merged

Self managed nodes move oke from exp #298

merged 14 commits into from
Jul 7, 2023

Conversation

shyamradhakrishnan
Copy link
Member

What this PR does / why we need it:
OKE self managed nodes and remove experimental of cluster and control plane

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #289

@shyamradhakrishnan
OKE self managed nodes
0cf1642
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
9578f85
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
d713ded
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
05adaf9
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
01aa8fd
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
4c5aadd
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
21d31f4
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
3320ed9
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
23735b7
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
a0504ea
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
c05e283
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
e3425f7
@shyamradhakrishnan
OKE self managed nodes and rmove OKE out of experimental
0e7bed8
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 5, 2023
joekr
joekr requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@joekr joekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small nits. This is awesome

test/e2e/managed_cluster_test.go Outdated Show resolved Hide resolved
cloud/scope/managed_control_plane.go Show resolved Hide resolved
cloud/scope/vnic_reconciler.go Show resolved Hide resolved
config/crd/bases/infrastructure.cluster.x-k8s.io_ocimanagedclusters.yaml Show resolved Hide resolved
docs/src/managed/self-managed-nodes.md Outdated Show resolved Hide resolved
exp/api/v1beta2/ocimanagedmachinepool_webhook.go Outdated Show resolved Hide resolved
exp/api/v1beta2/ocimanagedmachinepool_webhook_test.go Outdated Show resolved Hide resolved
exp/controllers/ocimachinepool_controller.go Outdated Show resolved Hide resolved
exp/controllers/ocivirtual_machinepool_controller_test.go Outdated Show resolved Hide resolved
@shyamradhakrishnan
Copy link
Member Author

unit test

?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	63.357s	coverage: 23.6% of statements
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta2	0.064s	coverage: 15.7% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/metrics	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.007s	coverage: 19.6% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	241.856s	coverage: 75.1% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/util	0.091s	coverage: 76.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/controllers	26.803s	coverage: 60.0% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1	15.682s	coverage: 16.5% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2	0.020s	coverage: 5.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/controllers	0.613s	coverage: 59.1% of statements
?   	github.com/oracle/cluster-api-provider-oci/feature	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/version	[no test files]
go tool cover -func=coverage.out -o coverage.txt
go tool cover -html=coverage.out -o coverage.html

@shyamradhakrishnan
Copy link
Member Author

e2e

  Timeline >>
  STEP: Tearing down the management cluster @ 07/06/23 05:43:33.548
  INFO: Error getting pod capi-kubeadm-bootstrap-system/capi-kubeadm-bootstrap-controller-manager-5996c56969-gbsrp, container manager: Get "https://127.0.0.1:40795/api/v1/namespaces/capi-kubeadm-bootstrap-system/pods/capi-kubeadm-bootstrap-controller-manager-5996c56969-gbsrp": dial tcp 127.0.0.1:40795: connect: connection refused
  INFO: Error getting pod capi-kubeadm-control-plane-system/capi-kubeadm-control-plane-controller-manager-85f84fcdcb-jfvn9, container manager: Get "https://127.0.0.1:40795/api/v1/namespaces/capi-kubeadm-control-plane-system/pods/capi-kubeadm-control-plane-controller-manager-85f84fcdcb-jfvn9": dial tcp 127.0.0.1:40795: connect: connection refused
  INFO: Error getting pod capi-system/capi-controller-manager-5fbc569749-g8fbl, container manager: Get "https://127.0.0.1:40795/api/v1/namespaces/capi-system/pods/capi-controller-manager-5fbc569749-g8fbl": dial tcp 127.0.0.1:40795: connect: connection refused
  INFO: Error getting pod cluster-api-provider-oci-system/capoci-controller-manager-7ddbd9f6bb-8c7w5, container manager: Get "https://127.0.0.1:40795/api/v1/namespaces/cluster-api-provider-oci-system/pods/capoci-controller-manager-7ddbd9f6bb-8c7w5": dial tcp 127.0.0.1:40795: connect: connection refused
  << Timeline
------------------------------

Ran 7 of 28 Specs in 3263.654 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 21 Skipped

@shyamradhakrishnan
Copy link
Member Author

self managed e2e test

Managed Workload cluster creation Managed Cluster - Self managed nodes
/home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/test/e2e/managed_cluster_test.go:325
Ran 1 of 28 Specs in 1344.825 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 27 Skipped

@shyamradhakrishnan shyamradhakrishnan merged commit 3cab342 into oracle:main Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OKE self managed nodes
2 participants