Fix: add nil check on Machine and Network Load Balancer #349
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tozastation <tozastation@gmail.com>
Signed-off-by: tozastation <tozastation@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
|
@tozastation please get the Oracle contribution agreement done before we can go ahead with the PR |
|
@shyamradhakrishnan |
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
tozastation
changed the title
|
Can you please attach unit test output please |
|
Sorry, the Oracle contribution agreement has been approved. |
|
@tozastation Can you please attach unit test output please, you can do via make test, and justpast the output here as a comment. |
|
Sorry, this is make test result ❯ make test
fatal: No names found, cannot describe anything.
GOBIN=/Users/tozastation/ghq/github.com/tozastation/cluster-api-provider-oci/hack/tools/bin ./scripts/go_install.sh sigs.k8s.io/controller-runtime/tools/setup-envtest setup-envtest v0.0.0-20230131074648-f5014c077fc3
kube-builder assets: /Users/tozastation/Library/Application Support/io.kubebuilder.envtest/k8s/1.24.2-darwin-arm64
KUBEBUILDER_ASSETS="/Users/tozastation/Library/Application Support/io.kubebuilder.envtest/k8s/1.24.2-darwin-arm64" go test -coverprofile=coverage.out ./...
? github.com/oracle/cluster-api-provider-oci [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/metrics [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/base [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn [no test files]
? github.com/oracle/cluster-api-provider-oci/feature [no test files]
? github.com/oracle/cluster-api-provider-oci/version [no test files]
ok github.com/oracle/cluster-api-provider-oci/api/v1beta1 24.432s coverage: 23.7% of statements
ok github.com/oracle/cluster-api-provider-oci/api/v1beta2 1.477s coverage: 15.6% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/ociutil 1.422s coverage: 19.6% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/scope 229.213s coverage: 75.1% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/util 1.094s coverage: 61.1% of statements
ok github.com/oracle/cluster-api-provider-oci/controllers 28.480s coverage: 58.7% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1 9.059s coverage: 15.3% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2 2.194s coverage: 4.8% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/controllers 4.350s coverage: 56.3% of statements
go tool cover -func=coverage.out -o coverage.txt
go tool cover -html=coverage.out -o coverage.html |
shyamradhakrishnan
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
cloud/scope/network_load_balancer_reconciler.gocloud/scope/machine.goWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #348