Upgrade OCI GO SDK to latest version #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrades Go SDK to latest version. It is good to update to latest version periodically and also we may need it to support Private Cloud Appliance.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Ran unit tests
➜ ~/oke/src/github.com/oracle/cluster-api-provider-oci git:(upgrade_oci_go_sdk) ✗ make test
/Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/bin/controller-gen "crd" rbac:roleName=manager-role webhook paths="./api/..." output:crd:artifacts:config=config/crd/bases
/Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./api/..."
go fmt ./...
go vet ./...
mkdir -p /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin
test -f /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin/setup-envtest.sh || curl -sSLo /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.8.3/hack/setup-envtest.sh
source /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin/setup-envtest.sh; fetch_envtest_tools /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin; setup_envtest_env /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin; go test ./... -coverprofile cover.out
Using cached envtest tools from /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin
setting up env vars
? github.com/oracle/cluster-api-provider-oci [no test files]
? github.com/oracle/cluster-api-provider-oci/api/v1beta1 [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok github.com/oracle/cluster-api-provider-oci/cloud/ociutil 0.397s coverage: 30.3% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/scope 76.170s coverage: 84.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn [no test files]
ok github.com/oracle/cluster-api-provider-oci/controllers 26.166s coverage: 69.3% of statements
Ran one functional test to make sure API calls are being made properly
• [SLOW TEST:672.810 seconds]
Workload cluster creation
/Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/test/e2e/cluster_test.go:49
Oracle Linux - With 1 control-plane nodes and 1 worker nodes
/Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/test/e2e/cluster_test.go:178
SSSSSSTEP: Tearing down the management cluster
JUnit report was created: /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/_artifacts/junit.e2e_suite.1.xml
Ran 3 of 16 Specs in 2777.572 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 13 Skipped
PASS