-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DRG based VCN peering #54
Merged
shyamradhakrishnan
merged 1 commit into
oracle:main
from
shyamradhakrishnan:add_drg_config
Apr 14, 2022
Merged
Add DRG based VCN peering #54
shyamradhakrishnan
merged 1 commit into
oracle:main
from
shyamradhakrishnan:add_drg_config
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyamradhakrishnan
force-pushed
the
add_drg_config
branch
2 times, most recently
from
April 7, 2022 06:37
36cf8be
to
fe74b93
Compare
Unit test
|
shyamradhakrishnan
force-pushed
the
add_drg_config
branch
3 times, most recently
from
April 7, 2022 10:38
04b609b
to
13e7b2b
Compare
e2e tests passed
|
joekr
requested changes
Apr 11, 2022
config/crd/bases/infrastructure.cluster.x-k8s.io_ociclusters.yaml
Outdated
Show resolved
Hide resolved
shyamradhakrishnan
force-pushed
the
add_drg_config
branch
4 times, most recently
from
April 13, 2022 10:39
47cf25d
to
447301d
Compare
joekr
reviewed
Apr 13, 2022
joekr
previously approved these changes
Apr 13, 2022
shyamradhakrishnan
force-pushed
the
add_drg_config
branch
from
April 14, 2022 03:07
447301d
to
c95ac54
Compare
shyamradhakrishnan
force-pushed
the
add_drg_config
branch
from
April 14, 2022 03:30
c95ac54
to
787ead8
Compare
joekr
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add DRG based VCN peering to CAPOCI
The CCM tests have been refactored to use latest image and remove the extra image which was required when CCM was not supporting 1.22
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #14
Functionality
Users can peer workload cluster VCN with any other VCN(typically management cluster VCN) via 2 methods. If both management cluster and workload cluster are in same region, then a single DRG can be used, and both the VCNs can be attached to the same VCN via VCN Attachment. If the management cluster and workload cluster are in separate regions, then they have to be peered using RPC.
Case 1: Same region
In this case, user provides the above YAML. In the DRG, CAPOCI will create a VCN Attachment with workload cluster VCN. DRG will not be managed in this case, thew ID has to be provided. The DRG can be shared across multiple workload clusters.
In the workload cluster VCN, the route rules specified will be added as DRG as the destination so that traffic to the management cluster will go via DRG.
Case 2: Different region
In this case, there will be a DRG per workload cluster. The DRG will be created by CAPOCI. After the DRG is created, CAPOCI will create RPCs in both the local and peer DRG. And then a connection will be initiated between the 2 RPCs.