-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClusterClass template for OCICluster #61
Merged
shyamradhakrishnan
merged 1 commit into
oracle:main
from
shyamradhakrishnan:add_cluster_class_template
Apr 13, 2022
Merged
Add ClusterClass template for OCICluster #61
shyamradhakrishnan
merged 1 commit into
oracle:main
from
shyamradhakrishnan:add_cluster_class_template
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test output
|
ClusterClass e2e test run
The ccm e2e test failed because of using wrong image, other tests passed
Ran the ccm e2e again with correct image
|
joekr
previously approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is just the one small copyright change but LGTM
shyamradhakrishnan
force-pushed
the
add_cluster_class_template
branch
from
April 13, 2022 03:48
5b3d7e2
to
d051cff
Compare
joekr
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR create an OCICluster template to be used in ClusterClass and creates e2e test for the same. The PR also fixes a bug in machine reconciler which was assuming ocicluster name was same as cluster name.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #59