Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where clusterctl move does not work, and add correct default … #74

Conversation

shyamradhakrishnan
Copy link
Member

Fix bug where clusterctl move does not work, and add correct default label

What this PR does / why we need it:

clusterctl move was not working in CAPOCI. This was because CAPOCI used the cluster UID to tag all OCI resources created, and during reconciliation, made sure that the tags matched. But during move, the cluster UID changes. So we cannot use cluster UID as the tag. Instead what we will do is to generate UID in the defaulter and use that to tag the OCI resources. This UID will not changes as it is not the auto-generated tag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #73

@shyamradhakrishnan
Copy link
Member Author

Unit test output

Using cached envtest tools from /Users/shyaradh/oke/src/github.com/oracle/cluster-api-provider-oci/testbin
setting up env vars
?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	2.839s	coverage: 7.8% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.521s	coverage: 30.3% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	180.930s	coverage: 81.9% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/controllers	32.241s	coverage: 71.0% of statements

e2e test output

• [SLOW TEST:563.289 seconds]
Workload cluster creation
/home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/test/e2e/cluster_test.go:49
  ClusterClass - with 1 control-plane nodes and 1 worker nodes [PRBlocking]
  /home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/test/e2e/cluster_test.go:470
------------------------------
STEP: Tearing down the management cluster


Ran 5 of 21 Specs in 1703.699 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 16 Skipped

api/v1beta1/ocicluster_webhook.go Show resolved Hide resolved
config/default/manager_image_patch.yaml Outdated Show resolved Hide resolved
config/default/kustomization.yaml Show resolved Hide resolved
@joekr joekr added bug Something isn't working enhancement New feature or request labels Apr 26, 2022
@joekr joekr self-requested a review April 26, 2022 17:27
@shyamradhakrishnan shyamradhakrishnan merged commit 5fe5f8b into oracle:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clusterctl move does not work with CAPOCI
2 participants