Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more MachinePool flexibility #94

Merged
merged 1 commit into from
May 25, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented May 24, 2022

What this PR does / why we need it:
This will now:

  • keep track of machine pool instances in status
  • variablize allowing public ips for the machine pool instances

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #90

@joekr joekr added the enhancement New feature or request label May 24, 2022
@joekr joekr self-assigned this May 24, 2022
cloud/scope/machine_pool.go Outdated Show resolved Hide resolved
cloud/scope/machine_pool.go Outdated Show resolved Hide resolved
cloud/scope/machine_pool.go Outdated Show resolved Hide resolved
cloud/scope/machine_pool.go Outdated Show resolved Hide resolved
This will now:

- keep track of machine pool instances in status
- variablize allowing public ips for the machine pool instances
@joekr
Copy link
Member Author

joekr commented May 24, 2022

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  0.260s  coverage: 18.6% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.712s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  176.165s        coverage: 73.9% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  26.302s coverage: 71.0% of statements
?       github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      [no test files]
?       github.com/oracle/cluster-api-provider-oci/exp/controllers      [no test files]
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]

e2e test

Ran 5 of 21 Specs in 1973.247 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 16 Skipped

@joekr joekr marked this pull request as ready for review May 24, 2022 16:26
@joekr joekr merged commit 861fc62 into oracle:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the MachinePool for better user experience
2 participants