Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.9 image with python-oracledb #2839

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add Python 3.9 image with python-oracledb #2839

merged 2 commits into from
Aug 1, 2024

Conversation

cjbj
Copy link
Member

@cjbj cjbj commented Jul 31, 2024

Everyone uses Oracle Database, right?

@cjbj
Add Python 3.9 image with python-oracledb
e337c5f 
Signed-off-by: Christopher Jones <christopher.jones@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 31, 2024
Djelibeybi
Djelibeybi requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Djelibeybi Djelibeybi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggested changes essentially switch to using our existing Python 3.9 image instead. Let me know if there's a particular reason you don't want to do this.

OracleLinuxDevelopers/oraclelinux8/python/3.9-oracledb/Dockerfile Outdated Show resolved Hide resolved
OracleLinuxDevelopers/oraclelinux8/python/3.9-oracledb/Dockerfile Outdated Show resolved Hide resolved
@cjbj
Fix review comment - start with a Python image
46c48f5 
Signed-off-by: Christopher Jones <christopher.jones@oracle.com>
Djelibeybi
Djelibeybi approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@Djelibeybi Djelibeybi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth changing the Python 3.6 one as well, but it's not urgent.

@Djelibeybi Djelibeybi merged commit ff99983 into oracle:main Aug 1, 2024
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djelibeybi Djelibeybi Djelibeybi approved these changes

@AmedeeBulle AmedeeBulle Awaiting requested review from AmedeeBulle AmedeeBulle is a code owner

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjbj @Djelibeybi