-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement static field base and offset substitutions for Unsafe #3284
Conversation
Hello ivan-ristovic, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address ivan -(dot)- ristovic95 -(at)- gmail -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
...vm.reflect/src/com/oracle/svm/reflect/target/Target_jdk_internal_misc_Unsafe_Reflection.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ivan-ristovic !
@ivan-ristovic , have you already signed and submitted the Oracle Contributor Agreement (OCA)? If not, please follow the instructions in step II here: https://www.graalvm.org/community/contributors/ |
Yes I have, and I have received a response long time ago. I assumed that the bot will automatically pick that up. |
@ivan-ristovic sorry for this, searching through the issues mentioning static field unsafe support I only found #2694 and #3020, not this PR unfortunately. |
@cstancu No worries! |
This PR implements
staticFieldOffset
andstaticFieldBase
methods incom.oracle.svm.core.jdk.SunMiscUnsafeSubstitutions