Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement static field base and offset substitutions for Unsafe #3284

Closed
wants to merge 6 commits into from
Closed

Implement static field base and offset substitutions for Unsafe #3284

wants to merge 6 commits into from

Conversation

ivan-ristovic
Copy link
Contributor

This PR implements staticFieldOffset and staticFieldBase methods in com.oracle.svm.core.jdk.SunMiscUnsafeSubstitutions

@graalvmbot
Copy link
Collaborator

Hello ivan-ristovic, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address ivan -(dot)- ristovic95 -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@vjovanov vjovanov requested a review from peter-hofer April 8, 2021 14:52
@vjovanov vjovanov self-assigned this Apr 8, 2021
Copy link
Member

@peter-hofer peter-hofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ivan-ristovic !

@peter-hofer
Copy link
Member

@ivan-ristovic , have you already signed and submitted the Oracle Contributor Agreement (OCA)? If not, please follow the instructions in step II here: https://www.graalvm.org/community/contributors/

@ivan-ristovic
Copy link
Contributor Author

Yes I have, and I have received a response long time ago. I assumed that the bot will automatically pick that up.

@peter-hofer peter-hofer self-assigned this Apr 9, 2021
@peter-hofer
Copy link
Member

Looks like @cstancu has already merged a PR with static fields support in Unsafe: 7df6884. Sorry about the timing, but thank you for your contribution!

Regarding the OCA, I have manually added you to our database so the bot should be satisfied alone in the future.

@peter-hofer peter-hofer closed this Apr 9, 2021
@cstancu
Copy link
Member

cstancu commented Apr 9, 2021

@ivan-ristovic sorry for this, searching through the issues mentioning static field unsafe support I only found #2694 and #3020, not this PR unfortunately.

@ivan-ristovic
Copy link
Contributor Author

@cstancu No worries!
@peter-hofer Roger, thanks!

@ivan-ristovic ivan-ristovic deleted the UnsafeSubstitutions branch July 25, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants