Add support for javax.cache:cache-api:1.1.1
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
commented
Jan 14, 2023
Comment on lines
+29
to
+46
| { | ||
| "condition": { | ||
| "typeReachable": "java.lang.Object" | ||
| }, | ||
| "name": "java.lang.String" | ||
| }, | ||
| { | ||
| "condition": { | ||
| "typeReachable": "java.lang.Object" | ||
| }, | ||
| "name": "java.lang.Number" | ||
| }, | ||
| { | ||
| "condition": { | ||
| "typeReachable": "java.lang.Object" | ||
| }, | ||
| "name": "java.lang.Integer" | ||
| } |
There was a problem hiding this comment.
- I was a bit surprised when I manually added these 3 GraalVM reachability metadata entries from nativeTest 's Error Log. This looks like something GraalVM needs to do, but now requires me to add them manually.
7 tasks
linghengqian
force-pushed
the
cache-api
branch
from
d8c29c8
to
3fb8fd2
Compare
dnestoro
reviewed
Jan 16, 2023
...ax.cache/cache-api/1.1.1/src/test/java/javax_cache/cache_api/core/stepbystep/SimpleTest.java
Outdated
Show resolved
Hide resolved
linghengqian
force-pushed
the
cache-api
branch
from
3fb8fd2
to
1695aff
Compare
dnestoro
approved these changes
Jan 16, 2023
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
javax.cache:cache-api:1.1.1#136 .com.hazelcast:hazelcast:5.2.1#169 and Add support fororg.ehcache:ehcache:3.10.8-jakarta#124 .Checklist before merging