Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcontainers/ryuk docker image to the allowed images list #262

Closed
wants to merge 1 commit into from

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Apr 3, 2023

What does this PR do?

$ grype testcontainers/ryuk:0.5.1
✔ Vulnerability DB        [updated]
 ✔ Parsed image            
 ✔ Cataloged packages      [27 packages]
 ✔ Scanning image...       [4 vulnerabilities]
   ├── 0 critical, 2 high, 2 medium, 0 low, 0 negligible
   └── 2 fixed
NAME          INSTALLED  FIXED-IN   TYPE  VULNERABILITY  SEVERITY 
libcrypto1.1  1.1.1t-r2             apk   CVE-2023-0466  Medium    
libcrypto1.1  1.1.1t-r2  1.1.1u-r0  apk   CVE-2023-2650  High      
libssl1.1     1.1.1t-r2             apk   CVE-2023-0466  Medium    
libssl1.1     1.1.1t-r2  1.1.1u-r0  apk   CVE-2023-2650  High

Checklist before merging

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

Copy link
Contributor Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Call @matneu to help with the review.

Copy link
Member

@matneu matneu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the testcontainers information here, ryuk has to run privileged, which is a no-go for us.

@linghengqian
Copy link
Contributor Author

  • @matneu Does the project allow global setting of .env file, in which TESTCONTAINERS_RYUK_DISABLED=true is configured by default? This will avoid the tedious setup of each test folder.

@dnestoro
Copy link
Member

@linghengqian we cannot allow global .env for docker images. Please close the PR unless you have some other idea how to solve this

@linghengqian
Copy link
Contributor Author

@linghengqian we cannot allow global .env for docker images. Please close the PR unless you have some other idea how to solve this

  • @dnestoro I have another question, are .env files allowed to exist in submodules where unit tests are located? The Contributor Guidelines don't make this clear.

@dnestoro
Copy link
Member

@linghengqian local env file is okay. We cannot allow global env files, but as long as you are affecting only your test, it is okay. Anyway, even with the env variable, do you still need this docker image for your test? If so, then @matneu can we accept this docker image if it is not run as privileged container?

@linghengqian
Copy link
Contributor Author

linghengqian commented Oct 23, 2023

@linghengqian local env file is okay. We cannot allow global env files, but as long as you are affecting only your test, it is okay. Anyway, even with the env variable, do you still need this docker image for your test? If so, then @matneu can we accept this docker image if it is not run as privileged container?

  • Thanks for the clarification. I will use a local .env file to introduce the use of testcontainers in the relevant unit tests of jetcd-core. This PR will be closed.

@linghengqian linghengqian deleted the new-image-second branch October 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable testcontainers tests once ryuk docker image is replaced with some less vulnerable
3 participants