Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library-and-framework-list.json #538

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashni-mehta
Copy link

Add MongoDB Drivers to list of tested libraries and frameworks.

What does this PR do?

This PR adds MongoDB JVM Drivers to the list of tested libraries and frameworks with GraalVM Native Image.

Code sections where the PR accesses files, network, docker or some external service

Checklist before merging

Add MongoDB Drivers to list of tested libraries and frameworks.
"https://github.com/mongodb/mongo-java-driver/tree/main/graalvm-native-image-app/src/main/resources/META-INF/native-image"
],
"tests_locations": [
"https://github.com/mongodb/mongo-java-driver/blob/main/.evergreen/run-graalvm-native-image-app.sh"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's specify https://github.com/mongodb/mongo-java-driver/tree/main/graalvm-native-image-app as the first location, and then specify the script you have specified.

The same applies to org.mongodb:mongodb-driver-reactivestreams.

@@ -1593,6 +1593,38 @@
}
]
},
{
"artifact": "org.mongodb:mongodb-driver-sync",
"description": "The official MongoDB Drivers for Java, Kotlin, and Scala",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of this artifact in Maven Central is "The MongoDB Synchronous Driver". Let's use the same one here. If it's not descriptive enough, then we should change it in https://github.com/mongodb/mongo-java-driver/blob/main/driver-sync/build.gradle. Also, org.mongodb:mongodb-driver-sync does not provide Kotlin/Scala APIs, nor do we test them with GraalVM.

{
"minimum_version": "5.2.0",
"metadata_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/graalvm-native-image-app/src/main/resources/META-INF/native-image"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata_locations should stay empty because we provide no metadata specific to org.mongodb:mongodb-driver-sync (it's not needed).

The same applies to org.mongodb:mongodb-driver-reactivestreams.

Comment on lines 1595 to +1596
},
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add entries for org.mongodb:mongodb-driver-core, org.mongodb:bson, org.mongodb:mongodb-crypt:

Suggested change
},
{
},
{
"artifact": "org.mongodb:mongodb-driver-core",
"description": "Shared components for the Synchronous and Reactive Streams implementations of the MongoDB Java Driver.",
"details": [
{
"minimum_version": "5.2.0",
"metadata_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/driver-core/src/main/resources/META-INF/native-image"
],
"tests_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/graalvm-native-image-app",
"https://github.com/mongodb/mongo-java-driver/blob/main/.evergreen/run-graalvm-native-image-app.sh"
],
"test_level": "fully-tested"
}
]
},
{
"artifact": "org.mongodb:bson",
"description": "The BSON library",
"details": [
{
"minimum_version": "5.2.0",
"metadata_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/bson/src/main/resources/META-INF/native-image"
],
"tests_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/graalvm-native-image-app",
"https://github.com/mongodb/mongo-java-driver/blob/main/.evergreen/run-graalvm-native-image-app.sh"
],
"test_level": "fully-tested"
}
]
},
{
"artifact": "org.mongodb:mongodb-crypt",
"description": "MongoDB client-side crypto support",
"details": [
{
"minimum_version": "5.2.0",
"metadata_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/mongodb-crypt/src/main/resources/META-INF/native-image"
],
"tests_locations": [
"https://github.com/mongodb/mongo-java-driver/tree/main/graalvm-native-image-app",
"https://github.com/mongodb/mongo-java-driver/blob/main/.evergreen/run-graalvm-native-image-app.sh"
],
"test_level": "fully-tested"
}
]
},
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants