Fix some remaining problems with disabling metrics, mostly deferring access to RegistryFactory (3.0) #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
previously approved these changes
Nov 22, 2021
|
Above forced push was to rebase after recent FT merge. |
tomas-langer
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3660
When metrics are disabled via config, we want to give the code a chance to set the MetricsSettings used for the RegistryFactory accordingly before the RegistryFactory is used by other Helidon code.
This PR fixes a few remaining issues with that.
The commits are grouped roughly by the affected area to simply reviews.