Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue-74 #173

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix for issue-74 #173

merged 2 commits into from
Jun 17, 2024

Conversation

Achal1607
Copy link
Member

Backport patch from NB-23.
For more info check apache/netbeans#7382

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 17, 2024
@lahodaj
Copy link
Member

lahodaj commented Jun 17, 2024

I think we need something like:

diff --git a/vscode/src/extension.ts b/vscode/src/extension.ts
index 3fd6e51feb..524dc6b0a3 100644
--- a/vscode/src/extension.ts
+++ b/vscode/src/extension.ts
@@ -1044,7 +1044,8 @@ function doActivateWithJDK(specifiedJDK: string | null, context: ExtensionContex
                     'jdk.hints',
                     'jdk.format',
                     'jdk.java.imports',
-                    'jdk.runConfig.vmOptions'
+                    'jdk.runConfig.vmOptions',
+                    'jdk.runConfig.cwd'
                 ],
                 fileEvents: [
                     workspace.createFileSystemWatcher('**/*.java')

so that the extension can read the CWD.

Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this patchfile, LGTM

Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Achal1607 Achal1607 merged commit 7776bd0 into oracle:main Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants