Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVSC #253 | adding new l10n content for zh_CN and ja in lsp module #325

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

naren2605
Copy link
Member

@naren2605 naren2605 commented Nov 10, 2024

adding new l10n content for zh_CN and ja in lsp module

Note: '{0}' seems like to be used by message formatter and expect esacaped quotes in translated content like ''{0}''

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 10, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naren2605 for getting these translations incorporated.

Please try and address the comments and queries I've left on a few of the message translations. Thanks.

@naren2605
Copy link
Member Author

Thanks @sid-srini will check these

Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naren2605. LGTM 👍

@sid-srini sid-srini merged commit bba9e60 into oracle:main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants