-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JVSC #253 | adding new l10n content for zh_CN and ja in lsp module #325
Conversation
4b1d191
to
5c49fdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @naren2605 for getting these translations incorporated.
Please try and address the comments and queries I've left on a few of the message translations. Thanks.
Thanks @sid-srini will check these |
5c49fdb
to
1ccc56d
Compare
1ccc56d
to
710cedf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @naren2605. LGTM 👍
adding new l10n content for zh_CN and ja in lsp module
Note:
'{0}'
seems like to be used by message formatter and expect esacaped quotes in translated content like''{0}''