Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVAVSCODE-16] Added option for running any Java project using context menu #75

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Achal1607
Copy link
Member

Added options in context menu for running and debugging any Java project. i.e. getting run java and debug java options when we right click on the java file, also we get these options when we right click on the code editor.

Closes #16

Image of how options look when we right click on a Java file in workspace

image

…va file

Signed-off-by: Achal Talati <achal.talati@oracle.com>
@Achal1607 Achal1607 requested a review from lahodaj November 10, 2023 04:58
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 10, 2023
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. One comment for consideration inline.

},
{
"command": "jdk.project.run",
"when": "nbJdkReady && editorLangId == java && resourceExtname == .java",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use both editorLangId == java and resourceExtname == .java? I would assume one should be enough, but don't mind too much.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes only resourceExtname == .java would be fine I guess but to be completely confident I have added both flags to check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I don't object to this.

@arvindaprameya
Copy link
Member

Looks good to me

@arvindaprameya arvindaprameya merged commit d9a1cb2 into oracle:main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: convenience methods to run/debug app
3 participants