Lint test files

oracle · Jan 22, 2020 · 0800b3c · 0800b3c
1 parent b947326
commit 0800b3c
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 9 deletions.
diff --git a/test/blobDMLBindAsBuffer.js b/test/blobDMLBindAsBuffer.js
@@ -32,7 +32,6 @@ var should   = require('should');
 var async    = require('async');
 var dbConfig = require('./dbconfig.js');
 var random   = require('./random.js');
-var fs       = require('fs');
 var assist   = require('./dataTypeAssist.js');
 
 describe('82.blobDMLBindAsBuffer.js', function() {

diff --git a/test/clobDMLBindAsString.js b/test/clobDMLBindAsString.js
@@ -30,7 +30,6 @@
 var oracledb = require('oracledb');
 var should   = require('should');
 var async    = require('async');
-var fs       = require('fs');
 var dbConfig = require('./dbconfig.js');
 var random   = require('./random.js');
 

diff --git a/test/cqn01.js b/test/cqn01.js
@@ -138,7 +138,7 @@ describe('224. cqn01.js', function() {
         eventEmitter.on("received", function() {
           console.log("Received message!");
           clearTimeout(timeout);
-          resolve()
+          resolve();
         });
       });
 
@@ -206,7 +206,7 @@ describe('224. cqn01.js', function() {
         eventEmitter.on("received", function() {
           console.log("Received message!");
           clearTimeout(timeout);
-          resolve()
+          resolve();
         });
       });
 

diff --git a/test/dbType01.js b/test/dbType01.js
@@ -35,7 +35,7 @@ describe('226. dbType01.js', function() {
   const default_stmtCacheSize = oracledb.stmtCacheSize;
 
   before(async () => {
-	oracledb.stmtCacheSize = 0;
+    oracledb.stmtCacheSize = 0;
     try {
       conn = await oracledb.getConnection(dbconfig);
     } catch (err) {
@@ -147,7 +147,7 @@ describe('226. dbType01.js', function() {
 
   it('226.9 DB_TYPE_NUMBER', async () => {
     try {
-	  const sql = `SELECT DUMP(:1) FROM dual`;
+      const sql = `SELECT DUMP(:1) FROM dual`;
       const result = await conn.execute(sql,
         [{ val: numInVal, type: oracledb.DB_TYPE_NUMBER }]);
       (result.rows[0][0]).should.startWith('Typ=2 Len=2');

diff --git a/test/list.txt b/test/list.txt
@@ -1289,6 +1289,13 @@ Overview of node-oracledb functional tests
         72.2.4 Negative - not providing first parameter
         72.2.5 promise test of createLob()
         72.2.6 call lob.close() multiple times sequentially
+    72.3 NCLOB
+        72.3.1 BIND_IN, DML, a txt file
+        72.3.2 BIND_IN, PL/SQL, a txt file
+        72.3.3 Negative - invalid type
+        72.3.4 Negative - invalid value
+        72.3.5 DML - UPDATE statement
+        72.3.6 BIND_INOUT, PL/SQL, IN LOB gets closed automatically
 
 73. poolPing.js
     73.1 the default value of poolPingInterval is 60

diff --git a/test/lobBind2.js b/test/lobBind2.js
@@ -945,6 +945,7 @@ describe("72. lobBind2.js", function() {
 
         lob.on("error", function(err) {
           should.not.exist(err, "lob.on 'error' event.");
+          reject(err);
         });
 
         lob.on("end", function() {
@@ -982,13 +983,14 @@ describe("72. lobBind2.js", function() {
 
         lob.on("error", function(err) {
           should.not.exist(err, "lob.on 'error' event.");
+          reject(err);
         });
 
         lob.on("finish", async function() {
           const sql = `insert into nodb_tab_nclob72 (id, content)
               values (:id, :bindvar)`;
           const result = await connection.execute(sql,
-              { id: seq, bindvar: lob});
+            { id: seq, bindvar: lob});
           should.strictEqual(result.rowsAffected, 1);
           await lob.close();
         }); // finish event
@@ -1035,6 +1037,7 @@ describe("72. lobBind2.js", function() {
 
         lob.on("error", function(err) {
           should.not.exist(err, "lob.on 'error' event.");
+          reject(err);
         });
 
         lob.on("finish", async function() {
@@ -1108,13 +1111,14 @@ describe("72. lobBind2.js", function() {
 
         lob.on("error", function(err) {
           should.not.exist(err, "lob.on 'error' event.");
+          reject(err);
         });
 
         lob.on("finish", async function() {
           const sql = `update nodb_tab_nclob72 set content = :bindvar
               where id = :id`;
           const result = await connection.execute(sql,
-              { id: seq, bindvar: lob});
+            { id: seq, bindvar: lob});
           should.strictEqual(result.rowsAffected, 1);
           await lob.close();
           await connection.commit();
@@ -1159,14 +1163,15 @@ describe("72. lobBind2.js", function() {
 
         lob.on("error", function(err) {
           should.not.exist(err, "lob.on 'error' event.");
+          reject(err);
         });
 
         lob.on("finish", async function() {
           const sql = `begin nodb_proc_nclob_inout1(:id, :io); end;`;
           const binds = {
             id: seq,
             io: { type: oracledb.DB_TYPE_NCLOB,
-                  dir: oracledb.BIND_INOUT, val: lob }
+              dir: oracledb.BIND_INOUT, val: lob }
           };
           const options = { autoCommit: true };
           const result = await connection.execute(sql, binds, options);
@@ -1183,6 +1188,7 @@ describe("72. lobBind2.js", function() {
 
             lobout.on("error", function(err) {
               should.not.exist(err, "lob.on 'error' event.");
+              reject(err);
             });
 
             lobout.on("end", async function() {