Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oke oss release 1.26.0 #426

Merged

Conversation

YashwantGohokar
Copy link
Member

@YashwantGohokar YashwantGohokar commented Jun 23, 2023

Change Log:

  • Bug fixes for CSI volume attachment issues & logging improvements
  • fixed filesystem cleanup for one of the fss e2e spec
  • Fixing snapshot test flakiness
  • Added support for CSI Snapshot-Restore
  • CSI Snapshot xfs bug fix and e2e enhancements
  • Changed 'fss' to 'csi-fss' in SanityCheckPV() in pvc_util.go
  • bumped oci-go-sdk to v65.40.1
  • Implement HTTP healthcheck for HTTPS backends
  • Detect change in IsPreserveSource to update it for NLB backend set
  • Retain LBs converted to flexible shape outside of K8s
  • Delete LB Listener and Backends before creating new listeners/backendsets
  • Changes associated with k8s v1.26.2
  • Improved network partition detection
  • Moved Update of Feature gate to cloud_provider_go and updated code as per review comment
  • Updating the changes for k8 v1.26.1
  • Custom check for CrossNamespaceVolumeDS
  • Updated files impacted due to upgrade of k8s v1.26

E2E Status:
All e2e tests are passing. Logs attached.
e2e-1.26.log
snapshot_opensource_e2e.log

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 23, 2023
@coveralls
Copy link

coveralls commented Jun 23, 2023

Pull Request Test Coverage Report for Build 5399633556

  • 139 of 579 (24.01%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 29.706%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/providers/oci/load_balancer_spec.go 23 24 95.83%
pkg/cloudprovider/providers/oci/load_balancer_util.go 13 14 92.86%
pkg/oci/client/load_balancer.go 2 6 33.33%
pkg/cloudprovider/providers/oci/load_balancer.go 0 16 0.0%
pkg/csi/driver/bv_node.go 0 72 0.0%
pkg/oci/client/block_storage.go 0 91 0.0%
pkg/csi/driver/bv_controller.go 101 356 28.37%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/providers/oci/load_balancer.go 1 30.21%
pkg/csi/driver/bv_controller.go 1 30.34%
pkg/csi/driver/bv_node.go 1 1.96%
Totals Coverage Status
Change from base Build 4292394607: 0.01%
Covered Lines: 3107
Relevant Lines: 10459

💛 - Coveralls

Copy link
Member

@pranavsriram8 pranavsriram8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good from CCM - LB perspective

@YashasG98
Copy link
Member

Please update version compatibilty matrix in readme

@YashasG98
Copy link
Member

@mrunalpagnis do we need to bump up provisioner version https://kubernetes-csi.github.io/docs/external-provisioner.html (the latest one is recommended for 1.26)

@YashasG98
Copy link
Member

image
These commits are not yet out in OKE, is it okay to include here?

@YashwantGohokar
Copy link
Member Author

image These commits are not yet out in OKE, is it okay to include here?

Yes. These are bug fixes and don't carry any new features.

@YashwantGohokar
Copy link
Member Author

@mrunalpagnis do we need to bump up provisioner version https://kubernetes-csi.github.io/docs/external-provisioner.html (the latest one is recommended for 1.26)

Bumped provisioner version and re-ran the csi E2Es:
e2e-1.26-csi.log

@YashwantGohokar
Copy link
Member Author

Please update version compatibilty matrix in readme

Updated the compatibility matrix.

mrunalpagnis
mrunalpagnis previously approved these changes Jun 28, 2023
Copy link
Member

@mrunalpagnis mrunalpagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback provided over DM and incorporated in PR hence approving

@YashwantGohokar YashwantGohokar merged commit 4102275 into oracle:master Jun 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants