Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect secret certificate name in Helm Chart #6

Open
alcampag opened this issue Jun 7, 2023 · 2 comments
Open

Incorrect secret certificate name in Helm Chart #6

alcampag opened this issue Jun 7, 2023 · 2 comments

Comments

@alcampag
Copy link
Member

alcampag commented Jun 7, 2023

Hi,

Currently, the name of the secret generated by cert-manager is not the same of the one in the deployment template.
The only workaround I have found is to set the value fullnameOverride: oci-native-ingress-controller but this is not documented as a requirement.
@nirpai
Copy link
Contributor

nirpai commented Jun 8, 2023 •
edited
Loading

Hi @alcampag, Thanks for reaching out. Taken note of above issue. Can you please provide the below details

  1. Command you ran for deploying the controller.
  2. Name of the secret generated by the cert-manager.

@alcampag
Copy link
Member Author

Hi,

  1. I installed the controller by syncing the chart through ArgoCD
  2. In helm/oci-native-ingress-controller/templates/webhook.yaml line 20 the name of the secret is hardcoded (oci-native-ingress-controller-tls), and this secret is referenced in helm/oci-native-ingress-controller/templates/deployment.yaml line 47, but this time the name of the secret is derived using a helm template function

My proposition here is to update the name of the secret in webhook.yaml so that it is aligned with the one in the deployment.

rozdolsky33 added a commit to rozdolsky33/oci-native-ingress-controller that referenced this issue Aug 29, 2023
@rozdolsky33
fixing issue oracle#6 update the name of the secret in webhook.yaml s…
5c7eee5 
…o that it is aligned with the one in the deployment
rozdolsky33 added a commit to rozdolsky33/oci-native-ingress-controller that referenced this issue Aug 30, 2023
@rozdolsky33
fixing issue oracle#6 update the name of the secret in webhook.yaml
0ef5571 
Signed-off-by: volodymyrrozdolsky <volodymyr.rozdolsky@oracle.com>
@rozdolsky33 rozdolsky33 mentioned this issue Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alcampag @nirpai