Ojdbc provider jackson oson #118
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
...c-provider-samples/src/main/java/oracle/jdbc/provider/oson/sample/JacksonOsonSampleUtil.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/OsonGenerator.java
Show resolved
Hide resolved
| @Override | ||
| public void writeUTF8String(byte[] buffer, int offset, int len) throws IOException { | ||
| _verifyValueWrite("writeUTF8String"); | ||
| gen.write(new String(buffer, offset, len, StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
OsonParserImpl and OsonGeneratorImpl have the ability to do UTF8 passthrough. See:
https://codesearch.oraclecorp.com/cs/xref/RDBMS_MAIN_LINUX.X64/dbjava/src/java/oracle/jdbc/driver/json/binary/OsonGeneratorImpl.java#2175
It would be great if we expose these methods and use them here to avoid string construction.
There was a problem hiding this comment.
These will have to be done on another version, since it would require changes to the driver
| @@ -0,0 +1,57 @@ | |||
| # OSON Provider for Jackson | |||
There was a problem hiding this comment.
Nice README. It would be great if you could include a definition of the type mappings, i.e. a table with one column that lists Java types and the default OSON mapping.
Also if I want to override a mapping for some field and gain access to the underlying OracleJsonParser and OracleJsonGenerator is this possible?
| protected void _verifyValueWrite(String typeMsg) throws IOException { | ||
| int status = _writeContext.writeValue(); | ||
| if(status == _writeContext.STATUS_EXPECT_NAME) { | ||
| _reportError("error: expecting value. Got name: " + typeMsg); |
There was a problem hiding this comment.
Should these strings be externalized for translation?
There was a problem hiding this comment.
For now error messages are not translated in the extensions.
| * of the JSON object. | ||
| * </p> | ||
| */ | ||
| public class AccessJsonColumnUsingJacksonObjectNode { |
There was a problem hiding this comment.
I think that this example should point out that this is only recommended if some existing API requires to consume the data as ObjectNode. Otherwise, it would be better to use OracleJsonObject as this will provide in-place reads of the underlying data without making a copy and it will better expose the underlying type system.
| public static void main(String[] args) { | ||
| try { | ||
| // set the system property to the class implementing the "oracle.jdbc.spi.JsonProvider interface" | ||
| System.setProperty(OracleConnection.CONNECTION_PROPERTY_PROVIDER_JSON, JacksonOsonProvider.PROVIDER_NAME); |
There was a problem hiding this comment.
Does this have to be done by system property?
There was a problem hiding this comment.
No, it can also be added as connection property, I have changed the samples.
...src/main/java/oracle/jdbc/provider/oson/sample/AccessJsonColumnUsingPOJOAndJsonProvider.java
Show resolved
Hide resolved
* Teking into account samples review comments * Added Copyright
…ta annotations. Added more Tests.
...rovider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/deser/OsonUUIDDeserializer.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/Util.java
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/OsonFactory.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/OsonGenerator.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/OsonModule.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/OsonModule.java
Outdated
Show resolved
Hide resolved
...ider-jackson-oson/src/main/java/oracle/jdbc/provider/oson/deser/OsonBooleanDeserializer.java
Outdated
Show resolved
Hide resolved
...er-jackson-oson/src/main/java/oracle/jdbc/provider/oson/deser/OsonLocalDateDeserializer.java
Outdated
Show resolved
Hide resolved
...ackson-oson/src/main/java/oracle/jdbc/provider/oson/deser/OsosnSerializableDeserializer.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-jackson-oson/src/test/java/oracle/jdbc/provider/oson/test/MultiThreadTest.java
Show resolved
Hide resolved
ojdbc-provider-samples/src/main/java/oracle/jdbc/provider/oson/sample/model/Emp.java
Show resolved
Hide resolved
|
Can't wait for this to be merged! |
No description provided.