Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directory listing API #4308

Merged
merged 5 commits into from
Apr 20, 2023
Merged

directory listing API #4308

merged 5 commits into from
Apr 20, 2023

Conversation

vladak
Copy link
Member

@vladak vladak commented Apr 19, 2023

This change introduces directory listing API.

There are couple of limitations:

  • only directories are supported at the moment, i.e. one cannot get the properties of individual file
  • not possible to list source root directly
  • There is no paging (like for the /history API endpoint); it is assumed that the number of entries in a directory is fairly low (hundreds of files).
  • the tests ought to have bigger coverage (DTO entry comparison, with/without extras, with path descriptions, authorization test, etc.)

At one point I contemplated moving the HTML production to a JSP, like it is mentioned in the comment in DirectoryListing#extraListTo(), however decided not to because the tests rely on the HTML/XML parsing.

@vladak vladak added the API label Apr 19, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 19, 2023
@vladak vladak merged commit 95c1e33 into oracle:master Apr 20, 2023
@vladak vladak deleted the directory_listing_api branch April 20, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant