-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lucene 9.12.0 #4570
base: master
Are you sure you want to change the base?
lucene 9.12.0 #4570
Conversation
public BitIntsHolder reduce(Collection<SuggestResultCollector> collectors) { | ||
BitIntsHolder reduced = documentIds; | ||
for (SuggestResultCollector collector : collectors) { | ||
documentIds.or(collector.documentIds); //TODO fix as per https://github.com/apache/lucene/pull/766/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs fixing
seems SuggestResultCollector.java has no testing coverage ... |
@ahornace any clues for proper fixing of reduce for that collector? Is it even used? |
@@ -205,18 +205,17 @@ private void searchMultiDatabase(List<Project> projectList, boolean paging) thro | |||
} | |||
|
|||
private void searchIndex(IndexSearcher searcher, boolean paging) throws IOException { | |||
collector = TopScoreDocCollector.create(hitsPerPage * cachePages, Short.MAX_VALUE); | |||
collectorManager = new TopScoreDocCollectorManager(hitsPerPage * cachePages, Short.MAX_VALUE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps redesign to reuse the object?
No description provided.