Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Platform should be optional #27

Closed
wants to merge 1 commit into from
Closed

Conversation

udzura
Copy link

@udzura udzura commented Oct 20, 2017

Hi,

struct Spec's member platform should be optional,
because current docker seems not to provide this in its config.json when invoke the runtime via docker-containerd-shim.
So this instruction is now broken.

(tested with Docker 17.09.0-ce on Ubuntu Zesty)

$ docker info
Containers: 22                      
 Running: 1                         
 Paused: 0                          
 Stopped: 21                                                             
Images: 1                                                                
Server Version: 17.09.0-ce          
Storage Driver: overlay2            
 Backing Filesystem: extfs          
 Supports d_type: true              
 Native Overlay Diff: true          
Logging Driver: json-file           
Cgroup Driver: cgroupfs             
Plugins:                            
 Volume: local                      
 Network: bridge host ipvlan macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive                     
Runtimes: rc runc                                                        
Default Runtime: runc               
Init Binary: docker-init            
containerd version: 06b9cb35161009dcb7123345749fef02f7cea8e0
runc version: 3f2f8b84a77f73d38244dd690525642a72156c64
init version: 949e6fa               
Security Options: 
 apparmor 
 seccomp 
  Profile: default                  
Kernel Version: 4.10.0-37-generic   
Operating System: Ubuntu 17.04      
OSType: linux                       
Architecture: x86_64                
CPUs: 2                             
Total Memory: 989.8MiB              
Name: ubuntu-zesty                  
ID: ...          
Docker Root Dir: /var/lib/docker    
Debug Mode (client): false          
Debug Mode (server): true           
 File Descriptors: 26               
 Goroutines: 42                     
 System Time: 2017-10-20T03:21:52.575539454Z                             
 EventsListeners: 0                 
Registry: https://index.docker.io/v1/                                    
Experimental: true                  
Insecure Registries:                
 127.0.0.0/8                        
Live Restore Enabled: false         

WARNING: No swap limit support      

@vishvananda
Copy link
Contributor

Thank you for this fix. It looks like the field was actually removed before the 1.0 release (opencontainers/runtime-spec#850). I'm thinking it might be better to just remove it rather than make it optional. If you would like to make that change and go sign the cla I can merge your code. Otherwise I can just make the change to remove it.

@udzura udzura force-pushed the optional-platform branch from 24c9e5f to d8b4881 Compare October 20, 2017 06:59
@udzura
Copy link
Author

udzura commented Oct 20, 2017

I got it. Changed codes to just remove lines and force-pushed. :D

@udzura udzura force-pushed the optional-platform branch from d8b4881 to 069c9a6 Compare October 20, 2017 07:03
Signed-off-by: Uchio KONDO <udzura@udzura.jp>
@vishvananda
Copy link
Contributor

this was fixed in 62575a5
Please resubmit if further changes are needed.

@udzura udzura deleted the optional-platform branch January 11, 2018 04:58
@udzura
Copy link
Author

udzura commented Jan 11, 2018

OK, Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants