Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truffle/truffle/fiddle_backend.rb may raise Polyglot::ForeignException #2714

Closed
kou opened this issue Sep 1, 2022 · 6 comments
Closed

truffle/truffle/fiddle_backend.rb may raise Polyglot::ForeignException #2714

kou opened this issue Sep 1, 2022 · 6 comments

Comments

@kou
Copy link
Contributor

kou commented Sep 1, 2022

It should raise Fiddle::Error or Fiddle::DLError to compatible with https://github.com/ruby/fiddle .

e.g.:

https://github.com/ruby-gettext/locale/runs/8130975674?check_suite_focus=true#step:5:8

/Users/runner/.rubies/truffleruby-head/lib/truffle/truffle/fiddle_backend.rb:262:in `<unknown>': dlopen(kernel32.dll, 2): image not found (Polyglot::ForeignException)
@eregon
Copy link
Member

eregon commented Sep 1, 2022

Thank you for the report, I'll take a look soon.

@eregon eregon self-assigned this Sep 1, 2022
@eregon
Copy link
Member

eregon commented Sep 2, 2022

There seems to be no test in Fiddle for this case. I guess I'll test this in ruby/spec then.

@eregon eregon added the bug label Sep 2, 2022
@eregon
Copy link
Member

eregon commented Sep 2, 2022

This is a regression since 22.1, it will be fixed soon.

@eregon eregon added this to the 22.3.0 milestone Sep 2, 2022
@eregon eregon added regression and removed bug labels Sep 2, 2022
graalvmbot pushed a commit that referenced this issue Sep 2, 2022
…issing library (#2714)

PullRequest: truffleruby/3477
@eregon
Copy link
Member

eregon commented Sep 13, 2022

@kou Could you maybe rerun https://github.com/ruby-gettext/locale/actions/runs/2970103655/jobs/4780349285 to check it works fine now?

@kou
Copy link
Contributor Author

kou commented Sep 13, 2022

@eregon
Copy link
Member

eregon commented Sep 13, 2022

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants