-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in Hash literals with invalid symbol keys #2848
Comments
nirvdrum
changed the title
Bug in hash literals with invalid symbol keys
Bug in Hash literals with invalid symbol keys
Feb 3, 2023
st0012
added a commit
to ruby/irb
that referenced
this issue
Feb 3, 2023
The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
st0012
added a commit
to ruby/irb
that referenced
this issue
Feb 3, 2023
The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
Fixed in 145d23e |
st0012
added a commit
to ruby/irb
that referenced
this issue
Feb 9, 2023
The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
st0012
added a commit
to ruby/irb
that referenced
this issue
Feb 9, 2023
The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
st0012
added a commit
to ruby/irb
that referenced
this issue
Feb 9, 2023
* Improve encoding error test case The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com> * Remove redundant TruffleRuby omits/pends Co-authored-by: Kevin Menard <kevin@nirvdrum.com> * Use a different way to test warning emission The test case was added in d08ef68 to verify that IRB emits Ruby warning as expected. But the subject it uses relies on CRuby's regexp engine, which isn't always used in other language implementations, like TruffleRuby. That's why we ended up skipping TruffleRuby in this test case. Since the test isn't about regexp itself, we can change the testing subject and just remove the special condition for TruffleRuby. Co-authored-by: Kevin Menard <kevin@nirvdrum.com> --------- Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
matzbot
pushed a commit
to ruby/ruby
that referenced
this issue
Feb 9, 2023
(ruby/irb#514) * Improve encoding error test case The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com> * Remove redundant TruffleRuby omits/pends Co-authored-by: Kevin Menard <kevin@nirvdrum.com> * Use a different way to test warning emission The test case was added in ruby/irb@d08ef68 to verify that IRB emits Ruby warning as expected. But the subject it uses relies on CRuby's regexp engine, which isn't always used in other language implementations, like TruffleRuby. That's why we ended up skipping TruffleRuby in this test case. Since the test isn't about regexp itself, we can change the testing subject and just remove the special condition for TruffleRuby. Co-authored-by: Kevin Menard <kevin@nirvdrum.com> --------- ruby/irb@6fdf4f3e97 Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While looking at some IRB test failures with @st0012, we came across a case where MRI raises an
EncodingError
but TruffleRuby raises nothing. Looking quickly at the specs, I didn't see anything in the language specs to test this behavior. The code in question is aHash
literal with a symbol key with an invalid encoding.Note, I didn't print the
Hash
directly because the invalid key will raise a separate exception on TruffleRuby when callingHash#inspect
.On MRI:
On TruffleRuby:
The text was updated successfully, but these errors were encountered: