-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dalli requires support for the connect_timeout
option to TCPSocket#initialize
#3421
Comments
Thanks for the report. In lib/truffle/socket/tcp_socket.rb the logic seems to currently use a blocking socket and blocking connect() call. Likely relevant snippet from
|
If this is aimed for 24.0 I think best to use the Timeout.timeout approach as it seems less risky (changing all socket fds to be non-blocking is likely a big change with many side effects). |
Co-authored-by: Manef Zahra <manef.zahra@shopify.com> Co-authored-by: Patrick Lin <patrick.lin@shopify.com> Co-authored-by: Kevin Menard <kevin.menard@shopify.com> Co-authored-by: Randy Stauner <randy.stauner@shopify.com> closes oracle#3421
Co-authored-by: Manef Zahra <manef.zahra@shopify.com> Co-authored-by: Patrick Lin <patrick.lin@shopify.com> Co-authored-by: Kevin Menard <kevin.menard@shopify.com> Co-authored-by: Randy Stauner <randy.stauner@shopify.com> closes oracle#3421
Co-authored-by: Manef Zahra <manef.zahra@shopify.com> Co-authored-by: Patrick Lin <patrick.lin@shopify.com> Co-authored-by: Kevin Menard <kevin.menard@shopify.com> Co-authored-by: Randy Stauner <randy.stauner@shopify.com> closes oracle#3421
We currently do not support the
connect_timeout
option toTCPSocket#initialize
. This has recently come up as a problem with Dalli 3.2.7, which started usingconnect_timeout
. This will impact those running Rails with memcache as its cache store.The text was updated successfully, but these errors were encountered: