Make interpolated strings frozen #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseaton
approved these changes
Mar 24, 2021
src/main/java/org/truffleruby/core/string/InterpolatedStringNode.java
Outdated
Show resolved
Hide resolved
kirs
force-pushed
the
frozen-interpolation
branch
from
f5614a2 to
8a0e7b4
Compare
eregon
reviewed
Mar 24, 2021
|
Looks good, and avoiding to change the semantics in the core library should limit the risk of this change. |
quasialaw
approved these changes
Mar 25, 2021
kirs
force-pushed
the
frozen-interpolation
branch
from
8a0e7b4 to
d3f8d50
Compare
graalvmbot
pushed a commit
that referenced
this pull request
Mar 25, 2021
PullRequest: truffleruby/2523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve #2303 by making strings that were built using interpolation frozen.
Before this patch, the line above printed
false. With this patch it printstrue. We think this better aligns with Ruby 2.7 behaviour, given that's the one that TruffleRuby aims to target:truffleruby 21.1.0-dev-90afa7e8, like ruby 2.7.2.