Make rpartition compatible with Ruby 2.7 #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseaton
reviewed
Apr 8, 2021
| @@ -205,7 +205,7 @@ def rpartition(pattern) | |||
| if pattern.kind_of? Regexp | |||
| if m = Truffle::RegexpOperations.search_region(pattern, self, 0, size, false) | |||
| Primitive.regexp_last_match_set(Primitive.caller_special_variables, m) | |||
| [m.pre_match, m[0], m.post_match] | |||
| return [m.pre_match, m[0], m.post_match] | |||
There was a problem hiding this comment.
Hmmm was this always effectively a typo then? A missing return?
|
Don't worry about the |
chrisseaton
approved these changes
Apr 8, 2021
gogainda
changed the title
eregon
approved these changes
Apr 12, 2021
eregon
reviewed
Apr 12, 2021
| end | ||
|
|
||
| it "returns new object if doesn't match" do | ||
| "hello".rpartition("/no_match/").last.object_id.should_not eql("hello".object_id) |
There was a problem hiding this comment.
.last.should_not.equal?("hello") is better here, I'll change to that.
Also we need to store the first "hello" in a variable because this file does not use frozen string literals.
|
@eregon is anything else I can do here? |
|
When it gains the |
|
In this case it was a transient failure in the internal CI (webrick being not thread-safe), I've restarted it. |
graalvmbot
pushed a commit
that referenced
this pull request
Apr 15, 2021
PullRequest: truffleruby/2557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly it's needed to fix failing tests of the mechanize gem.
Fixes #2321